[receiver/webhookevent] Add new json splitter to webhookeventreceiver #39768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shalper2 please review |
|
hey hey sorry for the long wait, i completely missed this! everything looks awesome just two minor requests on my end and a cheeky rebase should be enough |
1. add default to factory 2. Add tests to req_to_log_test.go
mterhar
force-pushed
the
mterhar.webhook-json-boundary
branch
from
478d35c to
3984b10
Compare
mterhar
changed the title
This was referenced May 13, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to split webhook body contents at JSON boundaries so you don't have to worry about newline characters.
Link to tracking issue
Fixes #39766
Testing
Added a test case to show newline vs json handling.
Documentation
Readme was updated with an additional example.