Skip to content

[opampsupervisor] remove health check port #39908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerHelmuth
Copy link
Member

Description

Removes the Agent's health_check_port feature. The opampsupervisor will no longer automatically start the collector with a healthcheck extension.

Testing

unit tests and e2e tests

@TylerHelmuth TylerHelmuth added Run Windows Enable running windows test on a PR Run ARM Enable running ARM tests on a PR labels May 6, 2025
@TylerHelmuth
Copy link
Member Author

I want to test merging the extensions list from local config and remote config before we merge this.

@evan-bradley
Copy link
Contributor

We have some logic to preserve lists under the services section of the config while merging the different sources in the Supervisor. Let me know if you see an issue with that during testing. I would have expected to see an E2E test covering this, but I don't; I'll look at adding one later.

Going forward, I think we should use the confmap.enableMergeAppendOption feature gate and pass the different config sources as separate files to the Collector and allow it to merge them.

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented May 7, 2025

@evan-bradley Checkout how in the e2e test I had to update the healthcheck collector config to list the opamp extensions. I wasn't expecting to have to do that when using a local config. Based on my debugging today it was something with the bootstrap process.

I'll investigate in depth tomorrow.

@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented May 7, 2025

I confirmed that adding

extensions:
  health_check:
    endpoint: localhost:13133
service:
  extensions: [opamp,health_check]

to a local config causes the supervisor's collector not to start. Investigating why, but I suspect this is a local config but about adding extensions via a local config.

@TylerHelmuth
Copy link
Member Author

I've confirmed this is an issue with local config including extensions: #39931

@evan-bradley evan-bradley merged commit 65bb39e into open-telemetry:main May 8, 2025
206 checks passed
@github-actions github-actions bot added this to the next release milestone May 8, 2025
@TylerHelmuth TylerHelmuth deleted the opampsupervisor-remove-health-check-port branch May 8, 2025 21:11
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor Run ARM Enable running ARM tests on a PR Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants