-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[opampsupervisor] remove health check port #39908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opampsupervisor] remove health check port #39908
Conversation
I want to test merging the extensions list from local config and remote config before we merge this. |
We have some logic to preserve lists under the Going forward, I think we should use the |
@evan-bradley Checkout how in the e2e test I had to update the healthcheck collector config to list the opamp extensions. I wasn't expecting to have to do that when using a local config. Based on my debugging today it was something with the bootstrap process. I'll investigate in depth tomorrow. |
I confirmed that adding extensions:
health_check:
endpoint: localhost:13133
service:
extensions: [opamp,health_check] to a local config causes the supervisor's collector not to start. Investigating why, but I suspect this is a local config but about adding extensions via a local config. |
I've confirmed this is an issue with local config including extensions: #39931 |
Description
Removes the Agent's
health_check_port
feature. The opampsupervisor will no longer automatically start the collector with a healthcheck extension.Testing
unit tests and e2e tests