[receiver/sqlserver] Emit another metric for direct connection #39940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/sqlserver
Run Windows
crobert-1
commented
May 7, 2025
|
Please resolve conflicts. |
crobert-1
force-pushed
the
sqlserver_page_life_expectancy
branch
from
243e52d to
7fcdf3f
Compare
Done 👍 |
sincejune
reviewed
May 12, 2025
crobert-1
force-pushed
the
sqlserver_page_life_expectancy
branch
from
b803cef to
cd2e210
Compare
sincejune
approved these changes
May 19, 2025
|
Ping @codeboten and @songy23 as PR assignees, I'm a code owner and this has already been approved by another code owner, this PR just needs sign off from an approver/maintainer. |
dehaansa
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR the
sqlserver.page.life_expectancymetric was only available when running on Windows as it was scraped from perf counters directly. This change enables the metric to be emitted also from directly connecting to SQL Server instances.Testing
Updated existing testing. #39930 adds this metric in the
configureAllScraperMetrics, otherwise it would have needed to be added here.Documentation
Removed documentation note that this metric was only available on Windows.