kafkareceiver: don't restart when marking errors #40140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a message is marked as consumed due to the message_marking configuration, log an error and continue instead of restarting the consumer. Restarting will not affect the outcome, it will cause a hit to throughput.
axw
force-pushed
the
kafkareceiver-messagemarking
branch
from
8f3617e to
8745308
Compare
MovieStoreGuy
approved these changes
May 28, 2025
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
#### Description If processing of a message fails but is still marked as consumed due to the `message_marking` configuration, log an error and continue instead of restarting the consumer. Restarting will not affect the outcome since the message will not be reprocessed due to being marked. #### Link to tracking issue Fixes open-telemetry#39909 #### Testing Added unit tests. #### Documentation None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If processing of a message fails but is still marked as consumed due to the
message_markingconfiguration, log an error and continue instead of restarting the consumer. Restarting will not affect the outcome since the message will not be reprocessed due to being marked.Link to tracking issue
Fixes #39909
Testing
Added unit tests.
Documentation
None