-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[pkg/ottl] A new OTTL function ParseInt
#40786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] A new OTTL function ParseInt
#40786
Conversation
cb118f3
to
d8d9117
Compare
d8d9117
to
849accd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on that @XuechunHou, and I'm sorry for the late review :)
I've left a few suggestions for your consideration.
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on that, LGTM!
Description
Added a
ParseInt
function that converts a stringified integer in a certain base into an int64.Link to tracking issue
Fixes
#40758
Testing
Added unit tests and e2e tests.
Documentation
Updated readme and added changelog entry.