Add skeleton for AWS ECS container metrics receiver #463

hossain-rayhan · 2020-07-15T19:30:41Z

Description:
Adding a feature: This change adds the skeleton for AWS ECS container metrics receiver. It reads
collection_interval from config file and ships some dummy metrics on that fixed interval.

Link to tracking Issue:
Closes #458

Testing:
Unit test added and executed locally.

Documentation:
README was added.

linux-foundation-easycla · 2020-07-15T19:30:44Z

The committers are authorized under a signed CLA.

✅ Rayhan Hossain (Mukla.C) (7aedd880288d6076a33d56bc34622d205e604104)

cmd/otelcontribcol/components.go

codecov · 2020-07-17T06:04:54Z

Codecov Report

Merging #463 into master will increase coverage by 0.07%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   86.04%   86.12%   +0.07%     
==========================================
  Files         203      206       +3     
  Lines       11230    11292      +62     
==========================================
+ Hits         9663     9725      +62     
  Misses       1236     1236              
  Partials      331      331

Flag	Coverage Δ
#integration	`57.03% <ø> (ø)`
#unit	`85.91% <96.77%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eceiver/awsecscontainermetricsreceiver/receiver.go	`92.59% <92.59%> (ø)`
...sreceiver/awsecscontainermetrics/metrics_helper.go	`100.00% <100.00%> (ø)`
receiver/awsecscontainermetricsreceiver/factory.go	`100.00% <100.00%> (ø)`
...eiver/awsxrayreceiver/internal/udppoller/poller.go	`100.00% <0.00%> (+2.43%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d97f3...3fd9d10. Read the comment docs.

.circleci/config.yml

config.yml

go.mod

receiver/awsecscontainermetricsreceiver/doc.go

receiver/awsecscontainermetricsreceiver/receiver.go

* Add debug logging to tail sampling filters Signed-off-by: Annanay <[email protected]> * Correct import order Signed-off-by: Annanay <[email protected]>

jrcamp · 2020-07-27T15:32:41Z

@hossain-rayhan patch codecov is still low and lint is failing (you can try running make lint locally)

jrcamp · 2020-07-29T14:55:42Z

@hossain-rayhan coverage check is still low. Please take a look at the coverage report to see what coverage you're missing. If you're not able to provide the required coverage please explain why it's not feasible for certain lines to not be covered.

jrcamp

Sorry for the delay, was out last week. Just one cleanup then lgtm.

receiver/awsecscontainermetricsreceiver/receiver_test.go

Description: This change adds the skeleton for AWS ECS container metrics receiver. It reads `collection_interval` from config file and ships some dummy metrics on that fixed interval.

jrcamp · 2020-08-12T20:36:50Z

@bogdandrutu @tigrannajaryan ready for merge

…ter.

hossain-rayhan · 2020-08-13T17:01:17Z

Detached my incomplete receiver from the component.go file. We can add it once my receiver is completely ready. Also, I guess it will help to get rid of the conflicts occurring every hour in top level go.mod and go.sum file.

* Change default value of 'parse_to' to 'attributes' * Fix tests in recently added operator

hossain-rayhan requested a review from a team July 15, 2020 19:30

hossain-rayhan changed the title ~~Add skeleton for Amazon ECS Task Metadata Endpoint~~ Add skeleton for Amazon ECS Task Metadata Endpoint receiver Jul 15, 2020

anuraaga reviewed Jul 16, 2020

View reviewed changes

cmd/otelcontribcol/components.go Outdated Show resolved Hide resolved

hossain-rayhan force-pushed the taskmetadata branch from cda062a to 7aedd88 Compare July 17, 2020 05:57

hossain-rayhan changed the title ~~Add skeleton for Amazon ECS Task Metadata Endpoint receiver~~ Add skeleton for AWS ECS container metrics receiver Jul 17, 2020

jrcamp suggested changes Jul 21, 2020

View reviewed changes

jrcamp self-assigned this Jul 22, 2020

hossain-rayhan force-pushed the taskmetadata branch 3 times, most recently from 176aa1c to 527e8d6 Compare July 25, 2020 01:02

hossain-rayhan force-pushed the taskmetadata branch from 7464d96 to 8f88d4c Compare July 27, 2020 23:27

hossain-rayhan force-pushed the taskmetadata branch from de4296c to 4ad2c95 Compare August 4, 2020 01:19

hossain-rayhan requested a review from jrcamp August 4, 2020 01:30

hossain-rayhan force-pushed the taskmetadata branch 2 times, most recently from 34f368e to ea7678c Compare August 4, 2020 18:14

jrcamp reviewed Aug 10, 2020

View reviewed changes

receiver/awsecscontainermetricsreceiver/receiver_test.go Outdated Show resolved Hide resolved

hossain-rayhan force-pushed the taskmetadata branch 3 times, most recently from 7c96c03 to 82256e2 Compare August 11, 2020 19:14

jrcamp approved these changes Aug 11, 2020

View reviewed changes

hossain-rayhan force-pushed the taskmetadata branch from 82256e2 to 6f28b49 Compare August 11, 2020 21:46

hossain-rayhan added 4 commits August 12, 2020 13:04

Add skeleton for AWS ECS container metrics receiver

9dd591e

Description: This change adds the skeleton for AWS ECS container metrics receiver. It reads `collection_interval` from config file and ships some dummy metrics on that fixed interval.

Remove unused code blocks and address PR feedbacks

53587cc

Fix lint and add a test case

5b53478

Add test coverage for the receiver

cf4e2e4

Utilize existing SinkMetricsExporterOld to test receiver

84eecf4

hossain-rayhan force-pushed the taskmetadata branch from 6f28b49 to 84eecf4 Compare August 12, 2020 20:07

jrcamp approved these changes Aug 12, 2020

View reviewed changes

hossain-rayhan added 3 commits August 13, 2020 09:12

Remove receiver from components as it is incomplete

8fd060a

Remove receiver from component as it is incomplete and merge with mas…

583f6e4

…ter.

Merge with master- get go.mod and go.sum from master

3fd9d10

tigrannajaryan merged commit 4533aa7 into open-telemetry:master Aug 13, 2020

bogdandrutu pushed a commit that referenced this pull request May 12, 2022

Change default value of 'parse_to' to 'attributes' (#463)

4672c7f

* Change default value of 'parse_to' to 'attributes' * Fix tests in recently added operator

codeboten pushed a commit that referenced this pull request Nov 23, 2022

[chore] Update main after 1.1.0 release (#463)

2ede3a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add skeleton for AWS ECS container metrics receiver #463

Add skeleton for AWS ECS container metrics receiver #463

Uh oh!

hossain-rayhan commented Jul 15, 2020 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Jul 15, 2020 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jul 17, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrcamp commented Jul 27, 2020

Uh oh!

jrcamp commented Jul 29, 2020

Uh oh!

jrcamp left a comment

Uh oh!

Uh oh!

jrcamp commented Aug 12, 2020

Uh oh!

hossain-rayhan commented Aug 13, 2020

Uh oh!

Uh oh!

Add skeleton for AWS ECS container metrics receiver #463

Add skeleton for AWS ECS container metrics receiver #463

Uh oh!

Conversation

hossain-rayhan commented Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrcamp commented Jul 27, 2020

Uh oh!

jrcamp commented Jul 29, 2020

Uh oh!

jrcamp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jrcamp commented Aug 12, 2020

Uh oh!

hossain-rayhan commented Aug 13, 2020

Uh oh!

Uh oh!

hossain-rayhan commented Jul 15, 2020 •

edited

Loading

linux-foundation-easycla bot commented Jul 15, 2020 •

edited

Loading

codecov bot commented Jul 17, 2020 •

edited

Loading