Update signalfx exporter translations #579
Conversation
dmitryax
commented
Jul 29, 2020
dmitryax
commented
- Rename more k8s specific dimensions and metrics
- Use cpu.num_processors instead of machine_cpu_cores
- Compute memory.total
- Split system.memory.usage
dmitryax
force-pushed
the
more-signalfx-exporter-translations
branch
from
b115c12 to
f913872
Compare
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 195 195
Lines 10608 10608
=======================================
Hits 9146 9146
Misses 1129 1129
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| k8s/node/condition_memory_pressure: kubernetes.node_memory_pressure | ||
| k8s/node/condition_network_unavailable: kubernetes.node_network_unavailable | ||
| k8s/node/condition_out_of_disk: kubernetes.node_out_of_disk | ||
| k8s/node/condition_p_i_d_pressure: kubernetes.node_p_i_d_pressure |
There was a problem hiding this comment.
Weird, is k8s/node/condition_p_i_d_pressure getting emitted? Should probably be k8s/node/condition_pid_pressure @asuresh4
There was a problem hiding this comment.
I'm going to handle this as the next PR with updating k8s cluster receiver to otel convention
There was a problem hiding this comment.
This is likely an artifact of the helper that converts camelcase to snakecase.
| @@ -119,14 +143,43 @@ translation_rules: | |||
|
|
|||
| - action: copy_metrics | |||
| mapping: | |||
| cpu.idle: machine_cpu_cores | |||
There was a problem hiding this comment.
Why is cpu.idle getting mapped to number cores? Isn't it converted in previous rule?
There was a problem hiding this comment.
it's a step to prepare for computation of cpu.num_processors in the next rule
There was a problem hiding this comment.
let me put a comment here
- Rename more k8s specific dimensions and metrics - Use cpu.num_processors instead of machine_cpu_cores - Compute memory.total - Split system.memory.usage
dmitryax
force-pushed
the
more-signalfx-exporter-translations
branch
from
f913872 to
bec99ca
Compare
* verify example. * fix review comments. * fix tools/go.* * remove leftover exit.
