[Azure Monitor Exporter] Correct HTTP status code -> success mapping according to specs #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status e.g. 101 - SwitchingProtocols should map to success
youngbupark
approved these changes
Jul 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
===========================================
+ Coverage 71.09% 86.26% +15.17%
===========================================
Files 14 195 +181
Lines 602 10632 +10030
===========================================
+ Hits 428 9172 +8744
- Misses 150 1128 +978
- Partials 24 332 +308
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pcwiese
changed the title
bogdandrutu
approved these changes
Aug 4, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Without using binary here, users will need the tools to compile psycopg2 on their systems.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
e.g. 101 - SwitchingProtocols should map to success
Testing:
[x] E2E tests with traces from the dotnet OTEL sdk