Add support for calculate new metric translator #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
===========================================
+ Coverage 71.09% 86.32% +15.22%
===========================================
Files 14 195 +181
Lines 602 10696 +10094
===========================================
+ Hits 428 9233 +8805
- Misses 150 1131 +981
- Partials 24 332 +308
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pmcollins
commented
Aug 4, 2020
pmcollins
commented
Aug 4, 2020
pmcollins
commented
Aug 4, 2020
pmcollins
commented
Aug 4, 2020
dmitryax
reviewed
Aug 4, 2020
|
Since memory.utilization is expected in percents, could you add a |
dmitryax
reviewed
Aug 4, 2020
dmitryax
reviewed
Aug 4, 2020
|
could you please cover the invalid input to increase the coverage? |
dmitryax
reviewed
Aug 5, 2020
pmcollins
changed the title
dmitryax
approved these changes
Aug 5, 2020
|
@bogdandrutu @tigrannajaryan can we merge this? |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Certain functions had V2 suffixes where it was necessary to have one. Even without a sufix they have different signature than equally-named old functions and thus the compiler can clearly distinguish between structs which implement the old of V2 interfaces. Removing the suffixes results in cleaner and more readable code. Some type names still have to use V2 suffix for now otherwise the names would conflict with existing old type names. Thanks, Jay for the hint.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds a translator so you can divide the value of one int metric with another. It produces a third metric which is a clone of the first metric, but has a float value that is the quotient of the first and second metric. Additionally, this change adds a rule to the default SFx rules that uses the new translator to produce a memory utilization value.
Link to tracking Issue: Not sure if one exists yet in GitHub
Testing: Unit tests were added to test both the divide metric functionality and the SFx rule that uses that functionality.
Documentation: Added inline.