kubeletstatsreceiver: Add metric_groups option #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 86.31% 86.37% +0.05%
==========================================
Files 196 197 +1
Lines 10754 10801 +47
==========================================
+ Hits 9282 9329 +47
Misses 1136 1136
Partials 336 336
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
kubeletstats-groups
branch
2 times, most recently
from
d49395b to
34b4829
Compare
|
loadtest failure seems unrelated. Trying a rebase to re-trigger tests. |
asuresh4
force-pushed
the
kubeletstats-groups
branch
from
34b4829 to
f9e8dd5
Compare
asuresh4
force-pushed
the
kubeletstats-groups
branch
from
f9e8dd5 to
a0b7867
Compare
|
Rebasing again, to re-trigger tests. |
Add a notion of metric groups in the receiver. Currently supports `container`, `pod` and `node` groups. By default, metrics from all groups will be collected.
asuresh4
force-pushed
the
kubeletstats-groups
branch
from
a0b7867 to
58a8f4a
Compare
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Translation is mostly based on OTLP to OC translation defined in translator/metrics/otlp_to_oc.go
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* trace exporter: using type names for return values * Update jaeger.go Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a notion of metric groups in the receiver. Currently supports
container,podandnodegroups. By default, metrics from all 3 groups will be collected. This can be overrode by setting themetric_groupoption. The idea is to extend the receiver to collect metricsvolumegroup as well in the future.Testing: Updated tests.
Documentation: Updated README.