Add working-set and page-fault metrics #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 86.61% 86.62% +0.01%
==========================================
Files 197 197
Lines 10748 10757 +9
==========================================
+ Hits 9309 9318 +9
Misses 1110 1110
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dmitryax
reviewed
Aug 8, 2020
|
Could you please add signalfx translations after to: It can be done as a separate PR |
|
Please add kubeletstats receiver to the commit message |
Done. |
Separate PR: #679 |
dmitryax
approved these changes
Aug 10, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Bump golangci-lint to 1.25 * Skip the "unused" linter when running golangci-lint in --fix mode This linter seems to provide bogus fix-up information to golangci-lint, which results in file corruption instead of fixing the issue. Since we are going to run the linter again anyway, but without the --fix mode, skip the "unused" linter explicitly for the first run - it will still have a chance to report errors on the second run.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
The CI is not able to catch many documentation problems because we are ignoring warnings. This commit fixes most of the warnings, ignores the rest and enables a flag to treat them as errors. Co-authored-by: Diego Hurtado <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds memory working set, page faults, and major page faults metrics to kubeletstats receiver.
Testing: Unit tests added using test fixtures recorded from minikube.