Migrate receiver creator to internal data model #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
convert-metrics-creator
branch
3 times, most recently
from
459ef24 to
8879641
Compare
bogdandrutu
reviewed
Aug 13, 2020
|
|
||
| // This is a copy of go.opentelemetry.io/collector/component/componenttest/example_factories.go | ||
| // migrated to internal data model | ||
| // TODO: Remove it once this package the one in core updated to support the new data model |
There was a problem hiding this comment.
dmitryax
force-pushed
the
convert-metrics-creator
branch
from
8879641 to
a49402b
Compare
bogdandrutu
reviewed
Aug 13, 2020
bogdandrutu
reviewed
Aug 13, 2020
| @@ -89,7 +91,7 @@ func (r *runnable) Run() error { | |||
| ctx := obsreport.ReceiverContext(r.ctx, typeStr, transport, r.receiverName) | |||
| for _, md := range mds { | |||
| ctx = obsreport.StartMetricsReceiveOp(ctx, typeStr, transport) | |||
| err = r.consumer.ConsumeMetricsData(ctx, *md) | |||
| err = r.consumer.ConsumeMetrics(ctx, pdatautil.MetricsFromMetricsData([]consumerdata.MetricsData{*md})) | |||
There was a problem hiding this comment.
Please create an issue to change line 89 kubelet.NewMetadata(r.extraMetadataLabels, podsMetadata) to return an array of non pointers to avoid this for loop :)
|
Fix the lint checks |
dmitryax
force-pushed
the
convert-metrics-creator
branch
3 times, most recently
from
c394f1a to
bac2f34
Compare
bogdandrutu
approved these changes
Aug 13, 2020
dmitryax
force-pushed
the
convert-metrics-creator
branch
from
bac2f34 to
faf22a6
Compare
This was referenced Aug 13, 2020
dmitryax
force-pushed
the
convert-metrics-creator
branch
2 times, most recently
from
a3867c5 to
3b057d6
Compare
Once simple prometheus exporter migrated to internal data model, it cannot be dynamically created anymore. This commit migrate receiver creator to internal data model along with other receivers that can be created dynamically: - kubeletstatsreceiver - redisreceiver The receivers are not migrated completely. For now they use converters. This fixes the currently broken build.
dmitryax
force-pushed
the
convert-metrics-creator
branch
from
3b057d6 to
daeb40f
Compare
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Once simple prometheus exporter migrated to internal data model, it cannot be dynamically created anymore. This commit migrate receiver creator to internal data model along with other receivers that can be created dynamically:
The receivers are not migrated completely. For now they use converters. This fixes the currently broken build.