Skip to content

sfxexporter: add disk usage translations #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2020
Merged

sfxexporter: add disk usage translations #760

merged 1 commit into from
Aug 18, 2020

Conversation

pmcollins
Copy link
Member

Description: Adds translations to produce disk.total, disk.summary_total, and df_complex.used_total metrics needed by the SFx backend.

Testing: Test data from local k8s env added to testdata dir and used in unit test.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #760 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         211      211           
  Lines       11400    11400           
=======================================
  Hits         9968     9968           
+ Misses       1093     1090    -3     
- Partials      339      342    +3     
Flag Coverage Δ
#integration 72.09% <ø> (ø)
#unit 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/dimensions/requests.go 84.48% <0.00%> (-8.63%) ⬇️
receiver/prometheusexecreceiver/receiver.go 85.29% <0.00%> (+2.20%) ⬆️
...eiver/awsxrayreceiver/internal/udppoller/poller.go 100.00% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660bbfb...0d79622. Read the comment docs.

@pmcollins pmcollins marked this pull request as ready for review August 18, 2020 19:48
@pmcollins pmcollins requested a review from a team August 18, 2020 19:48
@bogdandrutu bogdandrutu merged commit 1947955 into open-telemetry:master Aug 18, 2020
@pmcollins pmcollins deleted the disk-translations branch August 21, 2020 16:02
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
* botocore: Add Lambda extension

* add extension to add additional attributes for lambda invoke
  calls
* move lambda specific tests to separate module

* changelog

Co-authored-by: Diego Hurtado <[email protected]>
Co-authored-by: Owais Lone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants