Add AWSUniqueId and gcp_id generation in signalfxexporter #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
==========================================
+ Coverage 88.11% 88.17% +0.05%
==========================================
Files 233 233
Lines 12429 12465 +36
==========================================
+ Hits 10952 10991 +39
+ Misses 1120 1117 -3
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Aug 26, 2020
dmitryax
requested changes
Aug 26, 2020
dmitryax
approved these changes
Aug 27, 2020
| extraDimensions := make([]*sfxpb.Dimension, 0, len(nodeAttribs)+len(resourceAttribs)+1) | ||
|
|
||
| extraDimensions = appendResourceAttributesToDimensions(extraDimensions, resourceAttribs) | ||
| extraDimensions = appendAttributesToDimensions(extraDimensions, nodeAttribs) |
There was a problem hiding this comment.
nit: would be nice to have appendNodeAttributesToDimensions for consistency
There was a problem hiding this comment.
or we can keep it as is since the function is generic itself. so up to you
dmitryax
reviewed
Aug 27, 2020
These dimensions will be derived from the relevant resource attributes, if present. The resource attributes used to derive the values will be removed and thus not sent as dimensions.
Merged
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…ace/jaeger (#829) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: evantorrie <[email protected]> Co-authored-by: Liz Fong-Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These dimensions will be derived from the relevant resource attributes, if present.
The resource attributes used to derive the values will be removed and thus
not sent as dimensions.