-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix: “pointer to empty string” is not omitted bug of AWS X-Ray Exporter #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @EdZou - the change itself looks fine but could you please add a test to cover this case? /cc @kbrockhoff @anuraaga |
Hello @pjanotti I just added unit test, if you would like to review |
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 231 232 +1
Lines 12408 12412 +4
=======================================
+ Hits 10939 10943 +4
Misses 1114 1114
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks like there's a small build failure and one doc comment, but otherwise LGTM
internal/common/awsxray/util.go
Outdated
|
||
package awsxray | ||
|
||
// Util to check nil string pointer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Util to check nil string pointer | |
// String returns a pointer to the provided string, or nil if it is an empty string. |
Looks like just a flaky loadtest - @pjanotti @open-telemetry/collector-maintainers do you mind rerunning it and merging if things look ok? Thanks! |
Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ET <[email protected]> Co-authored-by: Liz Fong-Jones <[email protected]>
Description:
current exporter is broken because of #691 - unfortunately
omitempty
doesn’t work because “pointer to empty string” is not omitted.Now added a util function under "internal/common/awsxray" repository and take use of this to check the "pointer to empty string"
If you would like to check @anuraaga