Skip to content

SFx exporter: add delta translator #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 2, 2020
Merged

SFx exporter: add delta translator #839

merged 13 commits into from
Sep 2, 2020

Conversation

pmcollins
Copy link
Member

Description: Adds support for calculating sfx cumulative counter metrics from
non-delta metric sources.

Documentation: Translation rule docs added inline.

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #839 into master will increase coverage by 0.07%.
The diff coverage is 98.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   88.16%   88.23%   +0.07%     
==========================================
  Files         232      234       +2     
  Lines       12410    12504      +94     
==========================================
+ Hits        10941    11033      +92     
- Misses       1114     1115       +1     
- Partials      355      356       +1     
Flag Coverage Δ
#integration 72.00% <ø> (ø)
#unit 88.05% <98.01%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/signalfxexporter/translation/delta_translator.go 96.15% <96.15%> (ø)
exporter/signalfxexporter/config.go 91.83% <100.00%> (ø)
exporter/signalfxexporter/factory.go 89.18% <100.00%> (+0.30%) ⬆️
...xporter/signalfxexporter/translation/translator.go 96.61% <100.00%> (+0.06%) ⬆️
exporter/signalfxexporter/ttlmap/ttl_map.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb45b36...a2ef82b. Read the comment docs.

Adds support for calculating sfx cumulative counter metrics from
non-delta metric sources.
@pmcollins pmcollins marked this pull request as ready for review August 27, 2020 20:21
@pmcollins pmcollins requested a review from a team August 27, 2020 20:21
@dmitryax dmitryax self-assigned this Aug 28, 2020
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Just some nits.

@tigrannajaryan tigrannajaryan merged commit a244b07 into open-telemetry:master Sep 2, 2020
@dmitryax dmitryax mentioned this pull request Sep 14, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
…839)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: evantorrie <[email protected]>
Co-authored-by: Liz Fong-Jones <[email protected]>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants