Signalfx exporter: remove misleading warnings #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
reduce-noise-in-sfx-exporter
branch
2 times, most recently
from
28741ef to
1e748c1
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
reduce-noise-in-sfx-exporter
branch
from
1e748c1 to
d9496b4
Compare
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 88.14% 88.22% +0.08%
==========================================
Files 233 233
Lines 12412 12395 -17
==========================================
- Hits 10941 10936 -5
+ Misses 1125 1110 -15
- Partials 346 349 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
If summary metrics don't have quantiles or distribution metrics don't have buckets information, we still process those metrics, but at the same time we throw warnings saying that metric is dropped, and also we increase dropped metrics counter which is incorrect. Some prometheus libraries expose limited version of summary metrics that don't have quantiles at all https://prometheus.io/docs/practices/histograms/#library-support. There is nothing wrong with those metrics in general, so there is no reason to cause the noise in the exporter, even in debug mode. It's not the case for distribution metrics tho, but if we process them anyway, there is no way to through warnings in the exporter, it probably should be a debug log record at the receiver instead.
dmitryax
force-pushed
the
reduce-noise-in-sfx-exporter
branch
from
d9496b4 to
7ce83a7
Compare
dmitryax
changed the title
bogdandrutu
approved these changes
Aug 30, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add int array attribute support * Export int32, int64 and bool arrays * Export all other array attributes * Remove array test case from simple attr test * Addressed feedback Co-authored-by: Tyler Yahn <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
* code change to resolve the bug open-telemetry/opentelemetry-python-contrib#449 * modifying the changelog file to add entry for PR #869 * removing redundent get statement * Conditionally create server spans for falcon (#867) * Making span as internal for falcon in presence of a span in current context * Updating changelog * Fixing lint and generate build failures * Resolving comments: Converting snippet to re-usable function * Fixing build failures * Resolving comments: Creating wrapper for start span to make internal/server span * Rerun docker tests * Resolving comments: Refactoring * Fix Django 1.9 issue preventing use of MIDDLEWARE_CLASSES (#870) * Update CHANGELOG.md * Fix Django 1.9 issue preventing use of MIDDLEWARE_CLASSES Co-authored-by: Srikanth Chekuri <[email protected]> * changing the import trace statement to resolve issue with unit test cases Co-authored-by: Ashutosh Goel <[email protected]> Co-authored-by: Dan <[email protected]> Co-authored-by: Srikanth Chekuri <[email protected]> Co-authored-by: Owais Lone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If summary metrics don't have quantiles or distribution metrics don't have buckets information, we still process those metrics, but at the same time we throw warnings saying that metric is dropped, and also we increase dropped metrics counter which is incorrect.
Some prometheus libraries expose limited version of summary metrics that don't have quantiles at all https://prometheus.io/docs/practices/histograms/#library-support. There is nothing wrong with those metrics in general, so there is no reason to cause the noise in the exporter, even in debug mode. It's not the case for distribution metrics tho, but if we process them anyway, there is no value in throwing the warnings at the exporter, it probably should be a debug log record at the receiver instead.