Skip to content

Fix panic in newrelicexporter if service name is empty #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix panic in newrelicexporter if service name is empty #969

merged 1 commit into from
Sep 8, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 8, 2020

Resolves #964

Validate the Node and ServiceInfo are not nil pointers before dereferencing them. Additionally, add tests to prevent regression of this bug.

@MrAlias
Fix panic in newrelicexporter if service name is empty
9ef6982 
Resolves #964

Validate the Node and ServiceInfo are not nil pointers before
dereferencing them. Additionally, add tests to prevent regression of
this bug.
@MrAlias MrAlias requested a review from a team September 8, 2020 16:59
lykkin
lykkin approved these changes Sep 8, 2020
View reviewed changes
Copy link

@lykkin lykkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 ☕ 🍰

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 8, 2020

Test failure looks to be from the carbonexporter exporter. Looks like I don't have permissions to retry tests to see if it was intermittent.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #969 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   88.47%   88.46%   -0.01%     
==========================================
  Files         245      245              
  Lines       13089    13096       +7     
==========================================
+ Hits        11581    11586       +5     
- Misses       1148     1150       +2     
  Partials      360      360
Flag Coverage Δ
#integration 74.88% <ø> (ø)
#unit 87.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/newrelicexporter/newrelic.go 80.59% <100.00%> (+1.90%) ⬆️
exporter/newrelicexporter/transformer.go 94.81% <100.00%> (+0.02%) ⬆️
...eiver/awsxrayreceiver/internal/udppoller/poller.go 97.82% <0.00%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc0d37...9ef6982. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 3497570 into open-telemetry:master Sep 8, 2020
@MrAlias MrAlias deleted the 964 branch September 8, 2020 18:58
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@nilebox
Log when dropping metrics due to missing process_start_time_seconds (#…
4359f40 
…1921)

Report error via obsreport.EndMetricsReceiveOp and return error in transaction Commit()

Fixes #969
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@u5surf
Rename kv.Infer to kv.Any (#969) (#972)
6917167 
* Consider renaming Infer to Any. Any is a commonly used concept in Go.
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
b3e9a9a 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
f1e3f75 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
0638684 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
3e6cd90 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
bfe1fcc 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
e2b3b6b 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
703fa43 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
81a3de9 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
ae4a8a6 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
0969ea1 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
d2918a3 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
44f70b1 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
bc58e73 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
b3a68cd 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
a49c812 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
483e0fa 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
d97ce7d 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
39057c0 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
8ca32f0 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
7d4d2ce 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen
Rename remaining framework packages from "ext" to "instrumentation" (#…
55064ba 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
9b34d8a 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
3596cf6 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
de0df0f 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
30df06a 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
ae5926a 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
f61963c 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
bae6a12 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
0e5432e 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
afcc695 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
29d339e 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
536220c 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
23f785c 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
a975232 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
d3a3c26 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
e3f9b96 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
f450c89 
…969)
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@lzchen @codeboten
Rename remaining framework packages from "ext" to "instrumentation" (#…
3857183 
…969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lykkin lykkin lykkin approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewRelic exporter fails when no service name is provided
3 participants
@MrAlias @lykkin @bogdandrutu