Skip to content

SFx exporter: add float support to calculate new metric #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020
Merged

SFx exporter: add float support to calculate new metric #974

merged 1 commit into from
Sep 9, 2020

Conversation

pmcollins
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #974 into master will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   88.47%   88.47%   -0.01%     
==========================================
  Files         245      245              
  Lines       13089    13102      +13     
==========================================
+ Hits        11581    11592      +11     
- Misses       1148     1149       +1     
- Partials      360      361       +1     
Flag Coverage Δ
#integration 74.88% <ø> (ø)
#unit 87.68% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xporter/signalfxexporter/translation/translator.go 96.15% <90.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc0d37...67e9f0a. Read the comment docs.

@pmcollins pmcollins marked this pull request as ready for review September 9, 2020 14:23
@pmcollins pmcollins requested a review from a team September 9, 2020 14:23
@bogdandrutu bogdandrutu merged commit 2841b3e into open-telemetry:master Sep 9, 2020
@dmitryax dmitryax mentioned this pull request Sep 14, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants