-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[exporterhelper] Fix small batch due to scheduling in batch sender #10337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitryax
merged 17 commits into
open-telemetry:main
from
carsonip:batchsender-concurrency-tracking
Jun 12, 2024
Merged
[exporterhelper] Fix small batch due to scheduling in batch sender #10337
dmitryax
merged 17 commits into
open-telemetry:main
from
carsonip:batchsender-concurrency-tracking
Jun 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the number of goroutines in batch at once to workaround unfavorable goroutine scheduling. Fixes open-telemetry#9952
b8cc9f8
to
01b07b7
Compare
|
dmitryax
reviewed
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10337 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 387 387
Lines 18308 18312 +4
=======================================
+ Hits 16913 16917 +4
Misses 1049 1049
Partials 346 346 ☔ View full report in Codecov by Sentry. |
dmitryax
reviewed
Jun 11, 2024
dmitryax
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Fixes #9952
Testing
Added unit test
Documentation