Skip to content

Deprecated everything in exporterqueue, alias from exporterhelper #12706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 23, 2025

No description provided.

@bogdandrutu bogdandrutu requested review from a team, mx-psi, dmathieu and dmitryax as code owners March 23, 2025 20:52
@bogdandrutu bogdandrutu force-pushed the deprecate-exporterqueue branch 3 times, most recently from a6ec92a to 6d33d06 Compare March 23, 2025 21:05
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (622ce90) to head (bd0031c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/queue_batch.go 40.00% 3 Missing ⚠️
exporter/exporterhelper/logs.go 0.00% 0 Missing and 1 partial ⚠️
exporter/exporterhelper/metrics.go 0.00% 0 Missing and 1 partial ⚠️
exporter/exporterhelper/traces.go 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (81.81%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12706      +/-   ##
==========================================
- Coverage   91.53%   91.53%   -0.01%     
==========================================
  Files         483      482       -1     
  Lines       26453    26446       -7     
==========================================
- Hits        24215    24208       -7     
  Misses       1772     1772              
  Partials      466      466              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the deprecate-exporterqueue branch 2 times, most recently from f1730c4 to c154c1e Compare March 23, 2025 23:24
@bogdandrutu bogdandrutu force-pushed the deprecate-exporterqueue branch 2 times, most recently from c3b4d29 to 3365573 Compare March 24, 2025 17:07
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the default batch/queue sizer will be, actually -- can you update the comment here?

@bogdandrutu bogdandrutu force-pushed the deprecate-exporterqueue branch from 3365573 to bd0031c Compare March 24, 2025 18:23
@bogdandrutu bogdandrutu enabled auto-merge March 24, 2025 18:24
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 24, 2025
Merged via the queue into open-telemetry:main with commit 2bc783c Mar 24, 2025
55 of 56 checks passed
@bogdandrutu bogdandrutu deleted the deprecate-exporterqueue branch March 24, 2025 19:11
github-merge-queue bot pushed a commit that referenced this pull request Mar 24, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants