[confighttp] Use configoptional.Optional for optional fields
#13109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13109 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 522 522
Lines 28955 28955
=======================================
Hits 26508 26508
Misses 1931 1931
Partials 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I split off a couple of changes into separate PRs since those are clearer to me: |
|
Also, since I guess it is clear that |
…onal-in-confighttp
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…)(nil) (#13168) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Makes it so that unmarshaling into a `None[T]` is equivalent to unmarshaling into a `(*T)(nil)`. The goal is to be able to do #13109 without introducing any changes to the behavior. Needs #13161. <!--Describe what testing was performed and which tests were added.--> #### Testing Add a unit test to compare the behavior of unmarshaling into `(*T)(nil)` with that of unmarshaling into `None[T]` <!--Describe the documentation added.--> #### Documentation Amend docstrings <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the following changes to confighttp:
configoptional.Optionalinconfighttpfor all optional sectionsThis means a bunch of breaking changes. I think it is unfeasible to do this in two steps and I hereby promise that I will fix contrib tests and help anybody affected by this
Link to tracking issue
Fixes #9478