Add feature gate to disable log teeing when telemetry provider is set

.chloggen/fg_teeing.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: service
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Adds feature gate for disabling tee'ing when telemetry provider is configured.
+
+# One or more tracking issues or pull requests related to the change
+issues: [13209]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

service/go.mod

@@ -45,6 +45,7 @@ require (
 	go.opentelemetry.io/collector/receiver/receivertest v0.128.0
 	go.opentelemetry.io/collector/receiver/xreceiver v0.128.0
 	go.opentelemetry.io/collector/service/hostcapabilities v0.128.0
+	go.opentelemetry.io/contrib/bridges/otelzap v0.11.0
 	go.opentelemetry.io/contrib/otelconf v0.16.0
 	go.opentelemetry.io/contrib/propagators/b3 v1.36.0
 	go.opentelemetry.io/otel v1.36.0
@@ -111,7 +112,6 @@ require (
 	go.opentelemetry.io/collector/consumer/consumererror v0.128.0 // indirect
 	go.opentelemetry.io/collector/extension/extensionauth v1.34.0 // indirect
 	go.opentelemetry.io/collector/extension/extensionmiddleware v0.128.0 // indirect
-	go.opentelemetry.io/contrib/bridges/otelzap v0.11.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 // indirect
 	go.opentelemetry.io/contrib/zpages v0.61.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.12.2 // indirect

service/telemetry/logger.go

@@ -4,14 +4,25 @@
 package telemetry // import "go.opentelemetry.io/collector/service/telemetry"
 
 import (
+	"go.opentelemetry.io/contrib/bridges/otelzap"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/log"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
 
+	"go.opentelemetry.io/collector/featuregate"
+
 	"go.opentelemetry.io/collector/internal/telemetry/componentattribute"
 )
 
+var disableConsoleLoggingWhenProviderEnabled = featuregate.GlobalRegistry().MustRegister(
+	"telemetry.disableConsoleLoggingWhenProviderEnabled",
+	featuregate.StageAlpha,
+	featuregate.WithRegisterFromVersion("v0.129.0"),
+	featuregate.WithRegisterDescription("Disables console logging (tee-ing) when a logging provider is configured"),
+	featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector/issues/13019"),
+)
+
 // newLogger creates a Logger and a LoggerProvider from Config.
 func newLogger(set Settings, cfg Config) (*zap.Logger, log.LoggerProvider, error) {
 	// Copied from NewProductionConfig.
@@ -64,6 +75,20 @@
 
 		if len(cfg.Logs.Processors) > 0 && set.SDK != nil {
 			lp = set.SDK.LoggerProvider()
+
+			if disableConsoleLoggingWhenProviderEnabled.IsEnabled() {
+				attrs := attribute.NewSet()
+				otelCore, err := zapcore.NewIncreaseLevelCore(otelzap.NewCore(
+					"go.opentelemetry.io/collector/service/telemetry",
+					otelzap.WithLoggerProvider(lp),
+					otelzap.WithAttributes(attrs.ToSlice()...),
+				), zap.NewAtomicLevelAt(cfg.Logs.Level))
+				if err != nil {
+					panic(err)
+				}
+				return otelCore
+			}
+
 			core = componentattribute.NewOTelTeeCoreWithAttributes(
 				core,
 				lp,

service/telemetry/logger_test.go

@@ -13,6 +13,8 @@ import (
 	"testing"
 	"time"
 
+	"go.opentelemetry.io/collector/featuregate"
+
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	config "go.opentelemetry.io/contrib/otelconf/v0.3.0"
@@ -32,10 +34,11 @@ type shutdownable interface {
 
 func TestNewLogger(t *testing.T) {
 	tests := []struct {
-		name         string
-		wantCoreType any
-		wantErr      error
-		cfg          Config
+		name          string
+		wantCoreType  any
+		disableTeeing bool
+		wantErr       error
+		cfg           Config
 	}{
 		{
 			name:         "no log config",
@@ -80,6 +83,30 @@ func TestNewLogger(t *testing.T) {
 			},
 			wantCoreType: "*componentattribute.otelTeeCoreWithAttributes",
 		},
+		{
+			name: "log config with processors and tee'ing disabled",
+			cfg: Config{
+				Logs: LogsConfig{
+					Level:             zapcore.DebugLevel,
+					Development:       true,
+					Encoding:          "console",
+					DisableCaller:     true,
+					DisableStacktrace: true,
+					InitialFields:     map[string]any{"fieldKey": "filed-value"},
+					Processors: []config.LogRecordProcessor{
+						{
+							Batch: &config.BatchLogRecordProcessor{
+								Exporter: config.LogRecordExporter{
+									Console: config.Console{},
+								},
+							},
+						},
+					},
+				},
+			},
+			disableTeeing: true,
+			wantCoreType:  "*zapcore.levelFilterCore",
+		},
 		{
 			name: "log config with sampling",
 			cfg: Config{
@@ -109,6 +136,12 @@ func TestNewLogger(t *testing.T) {
 				Processors: tt.cfg.Logs.Processors,
 			}}))
 
+			if tt.disableTeeing == true {
+				_ = featuregate.GlobalRegistry().Set(disableConsoleLoggingWhenProviderEnabled.ID(), true)
+				defer func() {
+					_ = featuregate.GlobalRegistry().Set(disableConsoleLoggingWhenProviderEnabled.ID(), false)
+				}()
+			}
 			l, lp, err := newLogger(Settings{SDK: &sdk}, tt.cfg)
 			if tt.wantErr != nil {
 				require.ErrorContains(t, err, tt.wantErr.Error())