Skip to content

Preserve metric names during metricrequest #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lsj4401
Copy link

@lsj4401 lsj4401 commented Jun 19, 2025

Description

This PR fixes an issue in exporter/exporterhelper's sending_queue where metric names were lost during metricRequest splitting. Previously, when large batches of metrics were processed, the splitting logic in metric_batch.go could cause the name field of some metrics to disappear. This fix ensures that all metric fields are properly preserved when metricRequest objects are split.

Link to tracking issue

Fixes #13236

@lsj4401 lsj4401 requested review from bogdandrutu, dmitryax and a team as code owners June 19, 2025 14:58
Copy link

linux-foundation-easycla bot commented Jun 19, 2025

CLA Not Signed

@lsj4401 lsj4401 closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric names disappear when metricRequest is split in metric_batch.go with sending_queue
2 participants