Skip to content

Jaeger agent should not report ErrServerClosed #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Apr 20, 2021

The Jaeger agent reports ErrServerClosed when shutting down the service. This error is expected and should not be reported.

@pjanotti pjanotti requested a review from a team April 20, 2021 06:02
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2965 (8e6228a) into main (0a2ea1b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2965      +/-   ##
==========================================
- Coverage   91.63%   91.62%   -0.02%     
==========================================
  Files         312      312              
  Lines       15445    15445              
==========================================
- Hits        14153    14151       -2     
- Misses        883      884       +1     
- Partials      409      410       +1     
Impacted Files Coverage Δ
receiver/jaegerreceiver/trace_receiver.go 74.50% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2ea1b...8e6228a. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 8123ec3 into open-telemetry:main Apr 20, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants