Skip to content

Update the parameter names in LoggerProvider::GetLogger #2689

Open
@ThomsonTan

Description

@ThomsonTan

The following spec says name and version' for "Get a Logger" in LoggerProvider, but they are named as library_nameandlibrary_version` in the OpenTelemetry C++ API (see the second link below). Could the parameter names be updated to be consistent with the spec which could reduce confusion for the users coming from spec or SDK from other languages?

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/bridge-api.md#get-a-logger

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/api/include/opentelemetry/logs/logger_provider.h#L48

This is based on #2680 (comment).

Metadata

Metadata

Labels

StalebugSomething isn't workinggood first issueGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions