-
Notifications
You must be signed in to change notification settings - Fork 673
otelconf: skip flaky exporter tests on windows #7469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7469 +/- ##
=====================================
Coverage 81.5% 81.5%
=====================================
Files 198 198
Lines 17963 17963
=====================================
Hits 14647 14647
Misses 2917 2917
Partials 399 399 🚀 New features to boost your workflow:
|
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
FYI, we never had similar problems with https://github.com/signalfx/splunk-otel-go/blob/main/distro/otel_test.go where we do not even need to call |
Signed-off-by: Florian Bacher <[email protected]>
thanks for the link - it's rather odd why this issue appears only here - apart from the server being used for traces/metrics/logs simultaneously (e.g. https://github.com/signalfx/splunk-otel-go/blob/af5cdb19b988e6ad035a4401defe63c34febc7db/distro/otel_test.go#L852-L855) i don't really see anything that is fundamentally different from the tests here. Do you think there could be some concurrency issues in the |
No, I doubt it. |
Right now, I see you do not handle error when serving/shutting down. |
Is it always failing on |
i had a look at previous fails and all of them seem to be on windows, yes |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@pellared I have to admit I'm running out of ideas as to why the test fails randomly - should we skip this test for now (maybe at least for windows) to not cause any troubles for other PRs until we have figured out the root cause? |
I think we should do it as a temporary workaround. E.g. we could do if runtime.GOOS == "windows" {
// TODO (#7446): Fix the flakiness on Windows.
t.Skip("Test is flaky on Windows.")
} What do you think? |
sounds good - I will add that, and undo the changes to the timeout values, as they seemingly did not have any effect. I will keep the added error handling though |
Co-authored-by: Robert Pająk <[email protected]>
Can you please adjust the PR title? |
This PR disables the test execution of the exporter tests due to flakiness occurring on windows
Related to #7446