Ignore deprecation warnings about NameValidationScheme #6449

dmathieu · 2025-03-17T09:21:09Z

In 0.63.0, prometheus deprecates the model.NameValidationScheme attribute.
https://github.com/open-telemetry/opentelemetry-go/actions/runs/13885046847/job/38848614767?pr=6442

Error: exporter_test.go:478:6: SA1019: model.NameValidationScheme is deprecated: This variable should not be used and might be removed in the far future. If you wish to stick to the legacy name validation use IsValidLegacyMetricName() and LabelName.IsValidLegacy() methods instead. This variable is here as an escape hatch for emergency cases, given the recent change from LegacyValidation to UTF8Validation, e.g., to delay UTF-8 migrations in time or aid in debugging unforeseen results of the change. In such a case, a temporary assignment to LegacyValidation value in the init() function in your main.go or so, could be considered. (staticcheck)

We probably want to keep supporting this scheme in the near future though. So this ignores those deprecations, so we can upgrade the package.

Unblocks #6442

codecov · 2025-03-17T09:22:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.0%. Comparing base (f0ca595) to head (3898011).
Report is 1 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #6449   +/-   ##
============================
============================

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MrAlias · 2025-03-18T15:57:06Z

How long do we plan to support these deprecated features?

dmathieu · 2025-03-18T16:02:07Z

We haven't discussed that. I can bring it to the next SIG meeting.

MrAlias · 2025-03-18T16:07:59Z

Sounds good. I would prefer we drop support for deprecated features before we stabilize this module.

dmathieu · 2025-03-18T16:09:57Z

Ah yes, definitely. My thinking was to keep for one or two releases.

pellared · 2025-03-20T10:19:40Z

Ah yes, definitely. My thinking was to keep for one or two releases.

Let's create a tracking issue to not forget about it.

exporters/prometheus/config.go

pellared

I have come up with another way to notify the users about the deprecation at runtime.

CHANGELOG.md

exporters/prometheus/config.go

pellared · 2025-03-25T07:33:57Z

@XSAM, PTAL

# Overview Closes #6786 ### Added - Add exponential histogram support in `go.opentelemetry.io/otel/exporters/prometheus`. (#6421) - The `go.opentelemetry.io/otel/semconv/v1.31.0` package. The package contains semantic conventions from the `v1.31.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.31.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.30.0`. (#6479) - Add `Recording`, `Scope`, and `Record` types in `go.opentelemetry.io/otel/log/logtest`. (#6507) - Add `WithHTTPClient` option to configure the `http.Client` used by `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#6751) - Add `WithHTTPClient` option to configure the `http.Client` used by `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#6752) - Add `WithHTTPClient` option to configure the `http.Client` used by `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#6688) - Add `ValuesGetter` in `go.opentelemetry.io/otel/propagation`, a `TextMapCarrier` that supports retrieving multiple values for a single key. (#5973) - Add `Values` method to `HeaderCarrier` to implement the new `ValuesGetter` interface in `go.opentelemetry.io/otel/propagation`. (#5973) - Update `Baggage` in `go.opentelemetry.io/otel/propagation` to retrieve multiple values for a key when the carrier implements `ValuesGetter`. (#5973) - Add `AssertEqual` function in `go.opentelemetry.io/otel/log/logtest`. (#6662) - The `go.opentelemetry.io/otel/semconv/v1.32.0` package. The package contains semantic conventions from the `v1.32.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.32.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.31.0`(#6782) - Add `Transform` option in `go.opentelemetry.io/otel/log/logtest`. (#6794) - Add `Desc` option in `go.opentelemetry.io/otel/log/logtest`. (#6796) ### Removed - Drop support for [Go 1.22]. (#6381, #6418) - Remove `Resource` field from `EnabledParameters` in `go.opentelemetry.io/otel/sdk/log`. (#6494) - Remove `RecordFactory` type from `go.opentelemetry.io/otel/log/logtest`. (#6492) - Remove `ScopeRecords`, `EmittedRecord`, and `RecordFactory` types from `go.opentelemetry.io/otel/log/logtest`. (#6507) - Remove `AssertRecordEqual` function in `go.opentelemetry.io/otel/log/logtest`, use `AssertEqual` instead. (#6662) ### Changed - ⚠️ Update `github.com/prometheus/client_golang` to `v1.21.1`, which changes the `NameValidationScheme` to `UTF8Validation`. This allows metrics names to keep original delimiters (e.g. `.`), rather than replacing with underscores. This can be reverted by setting `github.com/prometheus/common/model.NameValidationScheme` to `LegacyValidation` in `github.com/prometheus/common/model`. (#6433) - Initialize map with `len(keys)` in `NewAllowKeysFilter` and `NewDenyKeysFilter` to avoid unnecessary allocations in `go.opentelemetry.io/otel/attribute`. (#6455) - `go.opentelemetry.io/otel/log/logtest` is now a separate Go module. (#6465) - `go.opentelemetry.io/otel/sdk/log/logtest` is now a separate Go module. (#6466) - `Recorder` in `go.opentelemetry.io/otel/log/logtest` no longer separately stores records emitted by loggers with the same instrumentation scope. (#6507) - Improve performance of `BatchProcessor` in `go.opentelemetry.io/otel/sdk/log` by not exporting when exporter cannot accept more. (#6569, #6641) ### Deprecated - Deprecate support for `model.LegacyValidation` for `go.opentelemetry.io/otel/exporters/prometheus`. (#6449) ### Fixes - Stop percent encoding header environment variables in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` and `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#6392) - Ensure the `noopSpan.tracerProvider` method is not inlined in `go.opentelemetry.io/otel/trace` so the `go.opentelemetry.io/auto` instrumentation can instrument non-recording spans. (#6456) - Use a `sync.Pool` instead of allocating `metricdata.ResourceMetrics` in `go.opentelemetry.io/otel/exporters/prometheus`. (#6472) --------- Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Robert Pająk <[email protected]>

ignore deprecation warnings about NameValidationScheme

f843117

dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 17, 2025

dmathieu mentioned this pull request Mar 17, 2025

[prometheus] Remove model.NameValidationScheme support #6450

Open

dmathieu marked this pull request as ready for review March 17, 2025 09:24

dmathieu requested review from MrAlias, XSAM, dashpole and pellared as code owners March 17, 2025 09:24

dmathieu mentioned this pull request Mar 17, 2025

fix(deps): update module github.com/prometheus/common to v0.63.0 #6442

Merged

1 task

pellared approved these changes Mar 20, 2025

View reviewed changes

exporters/prometheus/config.go Outdated Show resolved Hide resolved

capitalize and add dots

bcf9cf3

pellared reviewed Mar 21, 2025

View reviewed changes

exporters/prometheus/config.go Show resolved Hide resolved

dmathieu added 2 commits March 21, 2025 09:21

add changelog warning

bcca7d6

Merge branch 'main' into nolint-validation-scheme

55dd21e

dmathieu mentioned this pull request Mar 21, 2025

[After release] Remove support for model.LegacyValidation #6483

Closed

pellared reviewed Mar 21, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

exporters/prometheus/config.go Show resolved Hide resolved

dmathieu added 2 commits March 21, 2025 10:00

add deprecation entry to changelog too

a7a89e7

log once for uses of the legacy scheme

cddc916

pellared approved these changes Mar 21, 2025

View reviewed changes

Merge branch 'main' into nolint-validation-scheme

6864fa3

Merge branch 'main' into nolint-validation-scheme

cdb6f1d

XSAM approved these changes Mar 26, 2025

View reviewed changes

MrAlias approved these changes Mar 26, 2025

View reviewed changes

Merge branch 'main' into nolint-validation-scheme

3898011

dmathieu merged commit 905684c into open-telemetry:main Mar 27, 2025
29 of 30 checks passed

dmathieu deleted the nolint-validation-scheme branch March 27, 2025 08:41

MrAlias added this to the v1.36.0 milestone Mar 27, 2025

dmathieu mentioned this pull request May 19, 2025

Release v1.36.0/v0.58.0/v0.12.0 #6793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ignore deprecation warnings about NameValidationScheme #6449

Ignore deprecation warnings about NameValidationScheme #6449

Uh oh!

dmathieu commented Mar 17, 2025

Uh oh!

codecov bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

MrAlias commented Mar 18, 2025

Uh oh!

dmathieu commented Mar 18, 2025

Uh oh!

MrAlias commented Mar 18, 2025

Uh oh!

dmathieu commented Mar 18, 2025

Uh oh!

pellared commented Mar 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

pellared left a comment

Uh oh!

Uh oh!

Uh oh!

pellared commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Ignore deprecation warnings about NameValidationScheme #6449

Ignore deprecation warnings about NameValidationScheme #6449

Uh oh!

Conversation

dmathieu commented Mar 17, 2025

Uh oh!

codecov bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MrAlias commented Mar 18, 2025

Uh oh!

dmathieu commented Mar 18, 2025

Uh oh!

MrAlias commented Mar 18, 2025

Uh oh!

dmathieu commented Mar 18, 2025

Uh oh!

pellared commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pellared commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 17, 2025 •

edited

Loading

pellared commented Mar 20, 2025 •

edited

Loading