chore(Telemetry): set service.name from in telemetry release.name #1701
Conversation
Syndlex
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
| @@ -12,4 +12,4 @@ maintainers: | |||
| - name: jaronoff97 | |||
| - name: TylerHelmuth | |||
| icon: https://opentelemetry.io/img/logos/opentelemetry-logo-nav.png | |||
| appVersion: 0.127.0 | |||
| appVersion: 0.127.1 | |||
There was a problem hiding this comment.
you need to change the chart version not the app version here
There was a problem hiding this comment.
wow sorry.
Never contribute after 9 hours of work.
the default value is "otel-contrib" and this is irritating in telemetry values
Syndlex
force-pushed
the
chore/service_name
branch
from
5e13d2a to
1cd2ed1
Compare
| @@ -43,6 +43,11 @@ metrics: | |||
| {{- end }} | |||
| {{- end }} | |||
|
|
|||
| {{- define "opentelemetry-collector.telemetry.resource" -}} | |||
| resource: | |||
| service.name: "{{ .Release.Name }}" | |||
There was a problem hiding this comment.
I'm not actually sure whats typical for OTel's service.name semantic and a helm install. Should it be the release name or the fullname?
There was a problem hiding this comment.
that's a create question.
I like name more. Because in full name I always have Somethink like "PROD-"
Everything is better than "otel-contrib"
There was a problem hiding this comment.
If the default service.name was functional in previous releases, this could be a breaking change and should be documented in release notes. Users may have alerts tied to the current service.name value, especially for collector internal metrics.
I’d suggest using fullname instead, as it matches the collector’s k8s service name and better supports multiple chart instances in the same namespace or as subcharts. Open to considering all options though.
There was a problem hiding this comment.
Oh good point, I forgot the collector had a default service name.
@Syndlex we need to make this optional.
There was a problem hiding this comment.
What was the default service name?
When I do not set anything it is "otel-contrib" for me.
In my eyes this is would be wrong.
Optional would just mean don't setting it. Because it's setable from the current chart.
There was a problem hiding this comment.
When I do not set anything it is "otel-contrib" for me.
ya this is the default for the otel-contrib distro. For the k8s distro it would be otel-k8s.
We can't automatically set a new value for users since it will change their internal telemetry. They might have triggers, SLOs, boards, or other things that are expecting otel-contrib.
I agree it is already settable in .Values.config, but a lot of people don't realize you can do that. We could offer an option in the chart like serviceName: "" that when unset does nothing, but when set automatically configures the resource.
set service.name in telemetry from release.name
the default value is "otel-contrib" and this is irritating in telemetry values