Skip to content

feat: Add jvm.file_descriptor.count metric to JMX instrumentation #13722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2025
Merged

feat: Add jvm.file_descriptor.count metric to JMX instrumentation #13722

merged 5 commits into from
Apr 22, 2025

Conversation

schmikei
Copy link
Contributor

Follow up from open-telemetry/opentelemetry-java-contrib#1665

Specification PR that tracks this open-telemetry/semantic-conventions#1838 which seemed to have built consensus around jvm.file_descriptor.count which I am supportive of as well.

@trask
Copy link
Member

trask commented Apr 17, 2025

@schmikei would you mind also sending a semconv PR to add it there too?

@schmikei
Copy link
Contributor Author

@schmikei would you mind also sending a semconv PR to add it there too?

Thanks for the callout!

Here's the semantic PR -> open-telemetry/semantic-conventions#2139

@schmikei schmikei marked this pull request as ready for review April 17, 2025 15:42
@schmikei schmikei requested a review from a team as a code owner April 17, 2025 15:42
@SylvainJuge
Copy link
Contributor

Something to keep in mind is that this jvm.yaml file is not used as-is in the instrumentation, but only currently by the jmx-scraper in contrib.

For JVM metrics, it will also be relevant to modify the implementation(s) in instrumentation/runtime-telemetry, this will be only relevant once the semconv PR is approved and merged.

@laurit laurit added test openj9 This label can be applied to PRs to trigger them to run openj9 tests and removed test openj9 This label can be applied to PRs to trigger them to run openj9 tests labels Apr 21, 2025
laurit
laurit reviewed Apr 21, 2025
View reviewed changes
instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/jvm.yaml Outdated
metric: file_descriptor.count
type: updowncounter
unit: "{file_descriptor}"
desc: Number of open file descriptors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec has Number of open file descriptors as reported by the JVM.

@schmikei schmikei force-pushed the feat/add-jvm-target-system-metric branch from b0d9cfd to 5d9981d Compare April 21, 2025 14:46
@SylvainJuge
Copy link
Contributor

LGTM for the JMX implementation, please make sure to open an issue or PR to not forget about updating the implementation in instrumentation/runtime-telemetry.

@laurit laurit merged commit c86db65 into open-telemetry:main Apr 22, 2025
86 checks passed
@schmikei schmikei deleted the feat/add-jvm-target-system-metric branch April 22, 2025 14:38
@schmikei schmikei mentioned this pull request Apr 22, 2025
Closed
@schmikei schmikei mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmikei @trask @SylvainJuge @laurit