-
Notifications
You must be signed in to change notification settings - Fork 901
Add support for escaping declarative config env var substitution #7033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for escaping declarative config env var substitution #7033
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7033 +/- ##
============================================
+ Coverage 89.92% 89.96% +0.03%
- Complexity 6721 6723 +2
============================================
Files 765 765
Lines 20277 20293 +16
Branches 1985 1990 +5
============================================
+ Hits 18234 18256 +22
+ Misses 1448 1441 -7
- Partials 595 596 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oh, now I see the collector uses (Oops, had too many tabs open. This was supposed to be on the issue in the spec.) |
754d539
to
940dc1a
Compare
…4375) Resolves #3914. An environment variable substitution reference which starts with `$$` (i.e. `$${API_KEY}`) is escaped. Implementations should strip the leading `$` character and not perform substitution (i.e. `$${API_KEY} => ${API_KEY}`). See java implementation here: open-telemetry/opentelemetry-java#7033
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing @jaydeluca!
…y-java into escape-env-var-substitution
Implementation of spec PR: open-telemetry/opentelemetry-specification#4375