Skip to content

Promote EnvironmentResourceProvider to public API #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jack-berg
Copy link
Member

Based on this comment.

Users need to reference the FQCN when setting otel.java.enabled.resource.provider and otel.java.disabled.resource.provider. Having .internal. in the package name of such a prominent resource provider isn't a good look, so let's promote EnvironmentResourceProvider to part of the public API.

@jack-berg jack-berg requested a review from a team as a code owner January 29, 2025 15:56
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (c4412f2) to head (7a955c5).
Report is 8 commits behind head on main.

❌ Your project status has failed because the head coverage (89.95%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7052      +/-   ##
============================================
- Coverage     89.96%   89.84%   -0.13%     
+ Complexity     6664     6610      -54     
============================================
  Files           748      740       -8     
  Lines         20088    19981     -107     
  Branches       1970     1966       -4     
============================================
- Hits          18073    17951     -122     
- Misses         1423     1440      +17     
+ Partials        592      590       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 045c3e6 into open-telemetry:main Jan 31, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants