chore: restore lint:deps checking; fix some deps issues #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused dependencies (2) @opentelemetry/otlp-transformer packages/opentelemetry-test-utils/package.json @opentelemetry/core plugins/web/opentelemetry-plugin-react-load/package.json Unlisted dependencies (1) @opentelemetry/instrumentation plugins/web/opentelemetry-plugin-react-load/src/BaseOpenTelemetryComponent.ts
github-actions
bot
added
pkg:instrumentation-ioredis
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg:resource-detector-alibaba-cloud
pkg:resource-detector-aws
pkg:resource-detector-gcp
pkg:resource-detector-instana
pkg:propagation-utils
pkg:instrumentation-amqplib
pkg:instrumentation-lru-memoizer
pkg:instrumentation-mongoose
pkg:instrumentation-tedious
pkg:instrumentation-aws-sdk
pkg:instrumentation-cassandra-driver
pkg:instrumentation-fastify
pkg:instrumentation-koa
pkg:instrumentation-memcached
pkg:instrumentation-mongodb
pkg:instrumentation-pg
labels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 171 171
Lines 8140 8140
Branches 1652 1652
=======================================
Hits 7522 7522
Misses 618 618 |
pichlermarc
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
thanks 👍
Sorry - I should've checked that. In my mind @opentelemetry/instrumentation was a "safe" replacement as all of the instrumentation packages usually depend on it, but I was not considering that the react-load one is not an instrumentation package in that sense.
deejay1
pushed a commit
to deejay1/opentelemetry-js-contrib
that referenced
this pull request
Apr 14, 2025
…ry#2709) Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these 'lint:deps' hits:
lint:depswas accidentally removed in a merge-from-main in #2493.