-
Notifications
You must be signed in to change notification settings - Fork 581
fix: export KoaLayerType enum correctly #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
KoaLayerType is an enum. It was erroneously exported as a type causing errors on in Koa setups
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
=======================================
Coverage 89.73% 89.73%
=======================================
Files 187 187
Lines 9059 9059
Branches 1858 1858
=======================================
Hits 8129 8129
Misses 930 930 🚀 New features to boost your workflow:
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Hi @david-luna, need some assistance to get this PR approved/merged as breaks functionality from your recent commit 60612f2 (#2839) |
@cincauhangus thanks for the fix. Please run |
@david-luna done and ready for review/merge |
Short description of the changes
KoaLayerType is an enum. It was erroneously exported as a type causing errors on in Koa setups. This breaks the configuration setup for ignoring certain Koa Layers when publishing spans.
This was working in @opentelemetry/instrumentation-koa v0.46.0, now broken in v0.50.0.
Typescript linter error: