-
Notifications
You must be signed in to change notification settings - Fork 711
Relax protobuf version requirement to support v6 #4620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does tests pass for newer versions?
@emdneto I think running the workflows requires approval, are you able to do that? |
I am not the maintainer or even contributor, but based on the upgrading flow to The statement appeared in this issue/comment: #3958 (comment) |
Yes, I think this is the general agreement from the SIG. @bouk I mean, update the test-requirements.txt and run the tests. |
@emdneto done, and the tests pass |
Hi team, I don't know if you are aware of this https://nvd.nist.gov/vuln/detail/CVE-2025-4565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bouk, we’ll need to create two test-requirements files—one with proto5 and one with proto6—and do the same for components that use opentelemetry-proto, such as exporters. Do you have bandwidth for this? Lmk if not, and I can push the changes to your branch to get this reviewed and merged.
I have time for this tomorrow, sure. |
Fixes #4563, see that issue for details