Fix/copy measurement attributes #4627
Open
+141
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change gets the Measurement dataclass to create its own copy of the attributes that are passed to it. This stops changes to the attributes from outside the scope of the measurement affecting it.
I had considered making the Measurement attributes immutable, but that has a larger impact on the rest of the codebase and does more than just fix #4610.
Fixes #4610
Type of change
How Has This Been Tested?
Two new test files were added: a unit test and an integration test.
opentelemetry-sdk/tests/metrics/integration_test/test_data_point_creation.py::test_measurement_collection
opentelemetry-sdk/tests/metrics/test_measurement.py::test_measurement_attribute_is_a_different_object
opentelemetry-sdk/tests/metrics/test_measurement.py::test_measurement_attribute_uneffected_by_change
These are new files and pytest tests. There were a few
pytest
orunittest
tests in the project. Let me know if these tests would fit better in a different file, or asunittest
tests.Does This PR Require a Contrib Repo Change?
Checklist: