-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add reasoning_effort parameter to ModelSettings Fixes #189 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you also add this to openai_responses.py and openai_chatcompletions.py? Otherwise it's not actually used.
Co-authored-by: Rohan Mehta <[email protected]>
This reverts commit 1c20a7a.
hi @rm-openai the additions have been made, thank you!
|
Typechecking is failing I dont think Response has |
Thank you for taking the time to send this PR! The issue was resolved by #388 |
Description
This PR adds the reasoning_effort parameter to ModelSettings to allow configuration of reasoning effort as described in the OpenAI API docs.
Changes
Related Issues
Fixes #189
Testing