8396: OptionsCheckRule has doesn't recognize HeapDumpOnOutOfMemoryError #646
Conversation
I noticed that `HeapDumpOnOutOfMemoryError` was showing up as an undocumented rule, and that seemed a bit surprising. On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the `JAVA_8_DOCUMENTED_XX`. I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that? I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.
|
Hi @ivoanjo, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ivoanjo" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@ivoanjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde, @thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Hi @ivoanjo! Just type /covered in a comment to indicate that you are covered by the Datadog OCA. |
|
You'll also need to link this PR to https://bugs.openjdk.org/browse/JMC-8396 by adding |
|
/covered |
ivoanjo
changed the title
HeapDumpOnOutOfMemoryErrorHeapDumpOnOutOfMemoryError
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@ivoanjo This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@ivoanjo The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
Hey, it's green now! :) |
|
You still need to update the title to |
ivoanjo
changed the title
HeapDumpOnOutOfMemoryError
|
/integrate |
|
/sponsor |
|
Going to push as commit dd6fd90.
Your commit was automatically rebased without conflicts. |
|
@thegreystone @ivoanjo Pushed as commit dd6fd90. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I noticed that
HeapDumpOnOutOfMemoryErrorwas showing up as an undocumented rule, and that seemed a bit surprising.On a closer look, it's even documented on the exact link https://docs.oracle.com/javase/8/docs/technotes/tools/windows/java.html used as the source for the
JAVA_8_DOCUMENTED_XX.I googled and I don't think this option ever had another name, so it looks like a copy-paste accident or something like that?
I've submitted the needed docs for the OCA so I'm opening the PR for now and hopefully that will all be in good shape soon.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/646/head:pull/646$ git checkout pull/646Update a local copy of the PR:
$ git checkout pull/646$ git pull https://git.openjdk.org/jmc.git pull/646/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 646View PR using the GUI difftool:
$ git pr show -t 646Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/646.diff
Using Webrev
Link to Webrev Comment