fix: middleware type

[vicb]

assetResolver can be used regardless if the middleware is external

[changeset-bot]

🦋 Changeset detected

Latest commit: c487b2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@opennextjs/aws	Patch
app-pages-router	Patch
app-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@922

commit: c487b2f

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	26.93%	2639 / 9798
🔵	Statements	26.93%	2639 / 9798
🔵	Functions	54.26%	140 / 258
🔵	Branches	73.23%	621 / 848

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/adapters/middleware.ts	0%	0%	0%	0%	1-138
packages/open-next/src/build/generateOutput.ts	0%	0%	0%	0%	1-365
packages/open-next/src/build/validateConfig.ts	0%	0%	0%	0%	1-120
packages/open-next/src/core/createGenericHandler.ts	0%	0%	0%	0%	1-54
packages/open-next/src/core/resolve.ts	0%	100%	100%	0%	15-169
packages/open-next/src/types/open-next.ts	0%	0%	0%	0%

Generated in workflow #1353 for commit c487b2f by the Vitest Coverage Report Action

[Copilot]

Pull Request Overview

This PR refactors the middleware configuration type so that OpenNextConfig.middleware can be either an external or internal middleware config, and updates all related logic to use the new types.

• Introduces CommonMiddlewareConfig, ExternalMiddlewareConfig, and InternalMiddlewareConfig and updates OpenNextConfig.middleware.
• Updates resolver, output generation, and adapter code to cast and use ExternalMiddlewareConfig.
• Adjusts override extraction in createGenericHandler and adds conditional validation for external middleware.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/open-next/src/types/open-next.ts	Refactored middleware types and updated OpenNextConfig to use ExternalMiddlewareConfig or InternalMiddlewareConfig.
packages/open-next/src/core/resolve.ts	Changed resolveOriginResolver signature to accept ExternalMiddlewareConfig originResolver.
packages/open-next/src/core/createGenericHandler.ts	Guard override extraction to only pull .override when present on handler config.
packages/open-next/src/build/validateConfig.ts	Added validateFunctionOptions call for middleware only when external === true.
packages/open-next/src/build/generateOutput.ts	Extracted middlewareConfig for external middleware and updated originResolver/override access.
packages/open-next/src/adapters/middleware.ts	Cast global config to ExternalMiddlewareConfig and updated all resolver calls to use the cast config.
.changeset/slimy-turkeys-smoke.md	Added changeset entry for middleware configuration type fix.

Comments suppressed due to low confidence (3)

packages/open-next/src/types/open-next.ts:424

• [nitpick] The docblock above middleware only mentions external behavior. Consider expanding it to also describe how external: false (internal middleware) is handled.

  middleware?: ExternalMiddlewareConfig | InternalMiddlewareConfig;

packages/open-next/src/build/validateConfig.ts:112

• Add unit tests for validateConfig to cover both external: true and external: false middleware cases, ensuring validation logic runs only for external middleware.

  if (config.middleware?.external === true) {

packages/open-next/src/adapters/middleware.ts:38

• The optional chaining on middlewareConfig?.originResolver causes a type mismatch: resolveOriginResolver expects a non-undefined originResolver. Remove the ? so you pass middlewareConfig.originResolver.

    middlewareConfig?.originResolver,

[conico974]

LGTM

[vicb]

Thanks for the review Nico!