fix: include inspector links with information on if they are reachable. #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able booleans as values Signed-off-by: Carl Flottmann <[email protected]>
Signed-off-by: Carl Flottmann <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
reviewed
Jun 12, 2025
behnazh-w
approved these changes
Jun 12, 2025
AmineRaouane
pushed a commit
to AmineRaouane/macaron
that referenced
this pull request
Jun 17, 2025
…e. (oracle#1102) The detail info containing inspector links now contains links as keys regardless of whether they are reachable, and includes a boolean value for reachability. Signed-off-by: Carl Flottmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wheel_absence.pynow include inspector links regardless of if they are reachable or not in its detail information, along with a boolean for each identifying if it is reachable.Description of changes
Recently team members have had some troubles accessing PyPI inspector, and as a result observing that after running Macaron analysis, the inspector links are not provided in the output. To ensure the links are still available in the results, this PR now changes the detail information returned by
wheel_absence.pyto include the inspector links regardless of whether they are reachable or not. It also then include a boolean value identifying if it was reachable by that Macaron instance.Checklist
verifiedlabel should appear next to all of your commits on GitHub.