fix: accept from-provenance repos as scm authentic #1131
+47
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
reviewed
Jul 22, 2025
Signed-off-by: Ben Selwyn-Smith <[email protected]>
…nce available integration test Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
1128-fix-scm-authenticity
branch
from
b36d0b3 to
b144f9c
Compare
behnazh-w
approved these changes
Jul 23, 2025
behnazh-w
reviewed
Jul 23, 2025
| status=verification_result.status.value, | ||
| build_tool=verification_result.build_tool.name, | ||
| confidence=Confidence.MEDIUM, | ||
| reason="From provenance", |
There was a problem hiding this comment.
Why not using the RepositoryVerificationResult to be consistent with the implementation for inference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the SCM Authenticity check to allow acceptance of repository URLs found from provenance as being authentic.
Description of changes
The check is changed to allow non-Maven PURLs if they have provenance information with a from-repository URL. There are small changes compared to the Maven only implementation: The verification is automatically set to passed; the build tool is selected as either the first available, or set to unknown.
Related issues
Closes #1128