Issue#130 add docker sample that creates a domain #131

rakillen · 2018-06-20T15:03:20Z

add docker sample that creates a domain. Fixes #130

…ithub.com:oracle/weblogic-deploy-tooling into issue#130-add-docker-sample-that-creates-a-domain

mriccell

Richard I have made an initial review, please let me know if you have any questions.

mriccell · 2018-06-22T15:40:29Z

samples/docker-domain/Dockerfile

+    if [ -n "$WDT_MODEL" ]; then MODEL_OPT="-model_file /u01/$WDT_MODEL"; fi && \
+    if [ -n "$WDT_ARCHIVE" ]; then ARCHIVE_OPT="-archive_file /u01/$WDT_ARCHIVE"; fi && \
+    /u01/weblogic-deploy/bin/createDomain.sh \
+        -oracle_home /u01/oracle \


Use the ORACLE_HOME env

mriccell · 2018-06-22T15:41:26Z

samples/docker-domain/Dockerfile

+    /u01/weblogic-deploy/bin/createDomain.sh \
+        -oracle_home /u01/oracle \
+        -java_home ${JAVA_HOME} \
+        -domain_parent /u01/oracle/user_projects/domains \


Use a DOMAIN_HOME env

mriccell · 2018-06-22T15:43:27Z

samples/docker-domain/README.md

@@ -0,0 +1,50 @@
+Example Image with a  WLS Domain
+================================
+This Dockerfile extends the Oracle WebLogic image by creating a sample WLS 12.2.1.3 domain and cluster from a WebLogic Deploy Tool model.


The official name is Oracle WebLogic Deploy Tooling (WDT). Can you add a link to the GitHub project since it will be in the docker-images sample project.

mriccell · 2018-06-22T15:49:12Z

samples/docker-domain/README.md

+
+### WebLogic Deploy Tool
+
+The WebLogic Deploy Tool is used to create the domain image from a model file. Details about the tool and the model file format can be found in its GitHub project:


Give an example instead of differing to WDT project. You might want to say that a user can discover using WDT a preexisting domain which produces a yaml that captures the configuration. This yaml can be changed to specify specific configuration parameters and then the create script of WDT is used to create the domain inside the image.

mriccell · 2018-06-22T15:50:11Z

samples/docker-domain/README.md

+
+### How to Build and Run
+
+**NOTE:** The image is based on a WebLogic image in the Docker store: store/oracle/weblogic:12.2.1.3 . Verify that you have access to download this image.


download this image to your local repository.

mriccell · 2018-06-22T15:52:45Z

samples/docker-domain/README.md

+
+ 	$ docker run -d --name MS1 --link wlsadmin:wlsadmin -p 8001:8001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=<admin_password> -e MS_NAME=MS1 --volumes-from wlsadmin 12213-domain createServer.sh
+
+TBD To start a second Managed Server (MS2), run:


I haven't implemented the server start scripts yet. Would you rather just take these sections out until that is in place?

Why would the script to start MS1 different than the script to start MS2?

Oh I see so you do not have scripts to start MS1 or MS2, no this is fine since we will not commit to docker-images until everything is ready.

mriccell · 2018-06-22T15:53:32Z

samples/docker-domain/README.md

+
+ 	$ docker run -d --name MS2 --link wlsadmin:wlsadmin -p 8002:8001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=<admin_password> -e MS_NAME=MS2 --volumes-from wlsadmin 12213-domain createServer.sh
+
+The above scenario from this sample will give you a WebLogic domain with a cluster set up on a single host environment.


is the cluster a configure cluster a dynamic cluster or it does not matter?

I'd like it to be a dynamic cluster, if possible.

Currently just a configure cluster. Plan to make this a dynamic cluster when server scripts are ready.

mriccell · 2018-06-22T15:56:27Z

samples/docker-domain/build.sh

+#
+#Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
+#
+docker build \


Avi might ask that you have a buildDockerImage script similar to https://github.com/oracle/docker-images/blob/master/OracleWebLogic/samples/12213-webtier-apache/buildDockerImage.sh

OK, that looks pretty straightforward. Let me know if he wants to do this.

mriccell · 2018-06-22T16:03:44Z

samples/docker-domain/container-scripts/domain.properties

@@ -0,0 +1,2 @@
+ADMIN_PORT=7001


Why do you need this domain.properties if you have a simple-properties.yaml and can define the defaults in the Dockerfile

We don't currently use this for the admin startup script, not sure if we will need for the server scripts. One problem is that we can't easily extract the values we want from the yaml model file. I'll know more once we have startup scripts.

mriccell · 2018-06-22T16:04:33Z

samples/docker-domain/weblogic-deploy.zip.download

+#
+#  - wget https://github.com/oracle/weblogic-deploy-tooling/releases/download/weblogic-deploy-tooling-0.11/weblogic-deploy.zip
+#
+  weblogic-deploy.zip


Is there a checksum for this zip?

Github doesn't appear to offer checksum capabilities. We could put something in the release notes, but seems kinda odd.

rjeberhard · 2018-06-22T21:04:02Z

samples/docker-domain/Dockerfile

+# -----------------------
+# Put all downloaded files in the same directory as this Dockerfile
+# Run:
+#      $ sudo docker build \


We should tell customers where to put application binaries.

Or... make it clear that these should be included with the application model?

rjeberhard · 2018-06-22T21:06:02Z

samples/docker-domain/README.md

+================================
+This Dockerfile extends the Oracle WebLogic image by creating a sample WLS 12.2.1.3 domain and cluster from a WebLogic Deploy Tool model.
+
+Utility scripts are copied into the image, enabling users to plug Node Manager automatically into the Administration Server running on another container.


This is more a question, since I'm hoping to see them below, but... What are these scripts and what exactly do they do?

rjeberhard · 2018-06-22T21:07:00Z

samples/docker-domain/README.md

+
+ 	$ docker run -d --name MS2 --link wlsadmin:wlsadmin -p 8002:8001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=<admin_password> -e MS_NAME=MS2 --volumes-from wlsadmin 12213-domain createServer.sh
+
+The above scenario from this sample will give you a WebLogic domain with a cluster set up on a single host environment.


I'd like it to be a dynamic cluster, if possible.

rjeberhard · 2018-06-22T21:08:39Z

samples/docker-domain/container-scripts/startWLSDomain.sh

+
+# Start Admin Server and tail the logs
+${DOMAIN_HOME}/startWebLogic.sh
+touch ${DOMAIN_HOME}/servers/AdminServer/logs/AdminServer.log


We should discuss this as for K8s we're going to want the logs relocated outside the domain home to a file-system location where a persistent volume is mounted.

This is planned to have a dynamic cluster, still working on that. I think the log directory can be moved to persistent volume.

this statement does not preclude the logs being outside. The mechanism in Docker -v is used to map the logs outside of the container.

…-creates-a-domain' into issue#130-add-docker-sample-that-creates-a-domain

…ithub.com:oracle/weblogic-deploy-tooling into issue#130-add-docker-sample-that-creates-a-domain

tbarnes-us · 2018-06-25T19:14:09Z

This looks good to me. My only comment is that we may want to note that a domain-in-image's image needs to be protected with the same level of care as a stand-alone domain-home, since it contains sufficient information to decrypt WL passwords (the domain secret/SerializedSystemIni.dat). Derek, Monica, and I have discussed in more detail via Slack...

… model

rakillen added 8 commits June 19, 2018 17:29

Issue #130 - Add a docker sample that creates a domain from a WDT model

9650906

corrected domain directory owner

a67a8ef

Issue#127 - Update README.md

ef54a92

Issue#127 - Update WebLogic Deploy Tool download file

d2efccb

Issue #130 - corrected archive option name

d358e00

Issue #130 - enable build and deploy of simple application

07dae77

Merge branch 'issue#130-add-docker-sample-that-creates-a-domain' of g…

6b78d59

…ithub.com:oracle/weblogic-deploy-tooling into issue#130-add-docker-sample-that-creates-a-domain

Issue#127 - Added instructions for building the sample archive

bf1ee34

ddsharpe requested review from mriccell, rjeberhard and ddsharpe June 21, 2018 18:02

rakillen added 2 commits June 21, 2018 13:23

Issue#130 - Moved samples directory to top level

527f5d2

Issue #130 - change script permissions back to executable

6053557

mriccell reviewed Jun 22, 2018

View reviewed changes

rjeberhard reviewed Jun 22, 2018

View reviewed changes

rakillen added 6 commits June 22, 2018 17:24

Use environment variables in createDomain, corrected how-to

6102f25

Issue #130 - Updated README.md from review comments

daafc38

Issue #130 - Added checksum to download file

63f59d5

Merge remote-tracking branch 'origin/issue#130-add-docker-sample-that…

4025e20

…-creates-a-domain' into issue#130-add-docker-sample-that-creates-a-domain

Issue #130 - Corrected domain parent value

b815bf2

Merge branch 'issue#130-add-docker-sample-that-creates-a-domain' of g…

648d384

…ithub.com:oracle/weblogic-deploy-tooling into issue#130-add-docker-sample-that-creates-a-domain

ddsharpe previously approved these changes Jun 27, 2018

View reviewed changes

rakillen added 2 commits June 28, 2018 14:40

Issue #130 - Added script to start managed server

ae0d841

Issue #130 - Use dynamic cluster in model; use variables from file in…

ad86a0f

… model

rakillen dismissed ddsharpe’s stale review via ad86a0f June 28, 2018 18:43

rakillen added 2 commits June 28, 2018 17:09

Issue #130 - Deploy application to cluster, not admin server

7423c43

Issue#130 - Updated README.md with server start information

6ba3a70

ddsharpe approved these changes Jul 2, 2018

View reviewed changes

rakillen merged commit 05944bb into master Jul 2, 2018

rakillen deleted the issue#130-add-docker-sample-that-creates-a-domain branch July 3, 2018 21:25


		### WebLogic Deploy Tool

		The WebLogic Deploy Tool is used to create the domain image from a model file. Details about the tool and the model file format can be found in its GitHub project:


		### How to Build and Run

		NOTE: The image is based on a WebLogic image in the Docker store: store/oracle/weblogic:12.2.1.3 . Verify that you have access to download this image.


		$ docker run -d --name MS1 --link wlsadmin:wlsadmin -p 8001:8001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=<admin_password> -e MS_NAME=MS1 --volumes-from wlsadmin 12213-domain createServer.sh

		TBD To start a second Managed Server (MS2), run:


		$ docker run -d --name MS2 --link wlsadmin:wlsadmin -p 8002:8001 --env-file ./container-scripts/domain.properties -e ADMIN_PASSWORD=<admin_password> -e MS_NAME=MS2 --volumes-from wlsadmin 12213-domain createServer.sh

		The above scenario from this sample will give you a WebLogic domain with a cluster set up on a single host environment.

Issue#130 add docker sample that creates a domain #131

Issue#130 add docker sample that creates a domain #131

Uh oh!

Conversation

rakillen commented Jun 20, 2018

Uh oh!

mriccell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbarnes-us commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tbarnes-us commented Jun 25, 2018 •

edited

Loading