Remove JRF elements during discover #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsharpe
reviewed
Dec 18, 2018
|
Oops sorry I just saw Derek's review |
|
Thanks Carolyn :(
… On Dec 18, 2018, at 11:40 AM, Carolyn Rountree ***@***.***> wrote:
Oops sorry I just saw Derek's review
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_oracle_weblogic-2Ddeploy-2Dtooling_pull_200-23issuecomment-2D448306082&d=DwMCaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=BXvhOglyd-Xz2OX5cKsHkvm7qHDzFMjyuPeCtWdSQZM&m=C_S50v4gpMQrTHAkxqknO2VONwiAaS6MDtU8NXSlZgE&s=1i7K9cXiEBxJ3hHJ6Gk18CzB7WFR402vAplR8c07t0k&e=>, or mute the thread <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AiVlpmFIOznnifNJH-2DaxnLiRdjevl9eAks5u6ShwgaJpZM4ZYopi&d=DwMCaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=BXvhOglyd-Xz2OX5cKsHkvm7qHDzFMjyuPeCtWdSQZM&m=C_S50v4gpMQrTHAkxqknO2VONwiAaS6MDtU8NXSlZgE&s=wwRvGCQigIXlT87gi3JmfMVgMdeutXoKGLim7MVcXyI&e=>.
|
|
Hard to make this clearer in a concise way. We have the domain type name (JRF in this case) available, how about: <Skipping JRF shared library oracle.bi.jbips#[email protected]> This would fit with other possible types: <Skipping WLS shared library oracle.bi.jbips#[email protected]> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blacklists were added and applied for applications, coherence clusters, datasources, file stores, JMS resources, JMS servers, shared libraries, startup and shutdown classes, and WLDF resources. Fixes #199