Skip to content

allow empty string key in YAML to support server logging properties #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2020
Merged

allow empty string key in YAML to support server logging properties #540

merged 5 commits into from
Feb 13, 2020

Conversation

ddsharpe
Copy link
Member

@ddsharpe ddsharpe commented Feb 12, 2020 •
edited
Loading

Changed parser to allow empty string key in YAML keys in order to allow Logging properties to have things like "=Info". I, also, changed the discover YAML generator to quote the empty strings before writing them.

Like:

    Server:
        AdminServer:
            ListenAddress: 127.0.0.1
            ListenPort: 7001
            Log:
                LoggerSeverityProperties:
                    com.oracle.something: Debug
                    '': Info

rakillen
rakillen previously approved these changes Feb 12, 2020
View reviewed changes
core/src/main/python/wlsdeploy/yaml/yaml_translator.py
@@ -154,7 +154,7 @@ def _write_dictionary_to_yaml_file(self, dictionary, writer, indent=''):
"""
Do the actual heavy lifting of converting a dictionary and writing it to the file. This method is
called recursively when a value of the dictionary entry is itself a dictionary.
:param dictionary: the Python dictionarhy to converty
:param dictionary: the Python dictionary to convert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

CarolynRountree
CarolynRountree approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made changes to copyright

@ddsharpe ddsharpe merged commit 9d793a7 into master Feb 13, 2020
@ddsharpe ddsharpe deleted the allow-emptystring-key branch February 13, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakillen rakillen rakillen approved these changes

@CarolynRountree CarolynRountree CarolynRountree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddsharpe @rakillen @CarolynRountree