-
Notifications
You must be signed in to change notification settings - Fork 165
Clarify linker options in the guide are for GNU BFD #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
4795cce
to
c04b71f
Compare
Signed-off-by: Thomas Nyman <[email protected]>
c04b71f
to
f0f605e
Compare
Addressed feedback and resolved conflicts with main in f0f605e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential alternative wording. But current proposed wording also LGTM.
@@ -157,6 +157,8 @@ The recommendations in Table 1 and Table 2 are primarily applicable to compiling | |||
- supported both by the GCC and Clang / LLVM toolchains. | |||
- cross-platform and supported on (at least) Intel and AMD 64-bit x86 architectures as well as the 64-bit version of the ARM architecture (AArch64). | |||
|
|||
Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted). | |
Linker options covered by this guide are valid for tooling built off the GNU BFD (Binary File Descriptor) library (unless otherwise noted). Tools such as the GNU Linker (LD) and GNU Binary Utilities (binutils). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"GLD" isn't a commonly used term, and it's also ambiguous (could refer to the gold linker).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited
Fixes #923