Skip to content

Clarify linker options in the guide are for GNU BFD #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasnyman
Copy link
Contributor

Fixes #923

@thomasnyman thomasnyman force-pushed the linker-options-are-for-gnu-bfd branch from 4795cce to c04b71f Compare June 19, 2025 07:51
@thomasnyman thomasnyman force-pushed the linker-options-are-for-gnu-bfd branch from c04b71f to f0f605e Compare June 19, 2025 07:53
@thomasnyman
Copy link
Contributor Author

Addressed feedback and resolved conflicts with main in f0f605e.

Copy link
Contributor

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential alternative wording. But current proposed wording also LGTM.

@@ -157,6 +157,8 @@ The recommendations in Table 1 and Table 2 are primarily applicable to compiling
- supported both by the GCC and Clang / LLVM toolchains.
- cross-platform and supported on (at least) Intel and AMD 64-bit x86 architectures as well as the 64-bit version of the ARM architecture (AArch64).

Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted).
Copy link
Contributor

@06kellyjac 06kellyjac Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Linker options covered by this guide are valid for the GNU BFD linker (LD) provided by Binutils (unless otherwise noted).
Linker options covered by this guide are valid for tooling built off the GNU BFD (Binary File Descriptor) library (unless otherwise noted). Tools such as the GNU Linker (LD) and GNU Binary Utilities (binutils).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GLD" isn't a commonly used term, and it's also ambiguous (could refer to the gold linker).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Wl,--no-copy-dt-needed-entries is not universally understood! Depends on the BFD linker.
3 participants