-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
AlgosNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffDataFrameDataFrame data structureDataFrame data structureError ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasgood first issue
Milestone
Description
Is your feature request related to a problem?
when sort_values ascending parameter is set to a string (df.sort_values(col_name, ascending='False') it does not error although it's meaningless, this could be quite confusing.
Describe the solution you'd like
Raise an error if ascending is equal to values that are not boolean
API breaking implications
Error raising
Describe alternatives you've considered
Warning is also good, but I think error makes more sense
Additional context
for an hour I was wondering why ascending='False'
is not working
isinstance('False', bool) :)
Metadata
Metadata
Assignees
Labels
AlgosNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffDataFrameDataFrame data structureDataFrame data structureError ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasgood first issue