-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: Docstring for pandas.index.max #20130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Docstring for pandas.index.max #20130
Conversation
pandas/core/base.py
Outdated
Return the maximum value of the object. | ||
|
||
Return the maximum value of the object within the same type. | ||
Remember you also can access to a Dataframe's index as Dataframe.index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence may need some rewording
pandas/core/base.py
Outdated
@@ -791,7 +791,7 @@ def max(self): | |||
Return the maximum value of the object. | |||
|
|||
Return the maximum value of the object within the same type. | |||
Remember you also can access to a Dataframe's index as Dataframe.index. | |||
The Index of a DataFrame can be accessed as pandas.DataFrame.index. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rewrite the last sentence to:
The DataFrame Index can be accessed using pandas.DataFrame.index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Looks so nice |
pandas/core/base.py
Outdated
Return the maximum value of the object. | ||
|
||
Return the maximum value of the object within the same type. | ||
The DataFrame Index can be accessed using pandas.DataFrame.index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this last sentence is unecessary
pandas/core/base.py
Outdated
|
||
Returns | ||
------- | ||
object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scalar
pandas/core/base.py
Outdated
See Also | ||
-------- | ||
Index.min : Return the minimum value of the object. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link to Series.max, DataFrame.max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! =)
Hi @jreback, |
[ci skip]
Codecov Report
@@ Coverage Diff @@
## master #20130 +/- ##
=========================================
Coverage ? 91.72%
=========================================
Files ? 150
Lines ? 49152
Branches ? 0
=========================================
Hits ? 45086
Misses ? 4066
Partials ? 0
Continue to review full report at Codecov.
|
Thanks @JoanMartin 👍 |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.