-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Fixturize tests/frame/test_asof.py #25628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25628 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 173 173
Lines 52968 52968
=======================================
Hits 48339 48339
Misses 4629 4629
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25628 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 173 173
Lines 52968 52968
=======================================
Hits 48339 48339
Misses 4629 4629
Continue to review full report at Codecov.
|
pandas/tests/frame/conftest.py
Outdated
@pytest.fixture | ||
def date_range_frame(): | ||
""" | ||
Fixture for DataFrame of ints with date_range index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in love with this as a generalized fixture, if you put in test_asof would be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, the requirement was always that this should be on tests/frame/conftest
to be reusable for other test modules. But I don't care either way - can put it into test_asof.py
as well.
@jreback |
thanks |
Picking up #22471 again. Added one new fixture.