-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Pass the errors and kwargs arguments through to astype in the columns… #25888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7c2e092
Pass the errors and kwargs arguments through to astype in the columns…
johnklehm 11e5d42
test_generic.py - Add a test for astype dict errors ignore.
johnklehm d7c9d5a
Update the test data to relfect #25905. Add an explicit check for the…
johnklehm 0430b38
Add a whatsnew note about the bugfix for astype.
johnklehm 19afd08
Keep Python 3.5 happy by removing the f-strings.
johnklehm b04757a
ValueError inherits from Exception...so not_raises can be simplified.…
johnklehm 3a4849f
common.py - Fix an unused import vestigal from the not_raises simplif…
johnklehm 1c35cc7
Simplify the test by not checking explicitly for the exception it sho…
johnklehm 3190b0f
Remove some unused imports from the previous revisions.
johnklehm ce115a8
Remove the docstring from the test.
johnklehm f2dd79b
One line per dict formatting.
johnklehm 343e26c
PEP8 E241 fixes. Change the literals for the expected df to make it c…
johnklehm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.