CLN: Move base.StringMixin to computations.common #27746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Aug 4, 2019
|
|
||
|
|
||
| class StringMixin: | ||
| # TODO: delete this class. Removing this ATM caused a failure. |
There was a problem hiding this comment.
what does it cause to fail?
Is there a reason you are using "..." instead of "pass"?
There was a problem hiding this comment.
Yeah, pass is more normal, I'll change that.
There was a problem hiding this comment.
If you remove the inheriance from StringMixin in core.computatons.scope.py::Scope tests will fail. Haven't been able to fix it.
|
Generally +1. If you were inclined to try to separate out the just-for- |
|
I’ve updated the PR. |
|
thanks @topper-123 |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringMixinshould be removed, but I can't figure out how to remove it without breaking tests, so this movesStringMixinto core.computation, which is the only module, where it is currently used.This makes
core.base.pya bit cleaner.